-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson 8: onSale #6
Comments
If the Btw just a nitpick: the attribute is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not a real issue, more of a question actually.
On this lesson the onSale property is used combined with the computed property sale. But when you change the onSale value, the p tag stays on the page and shows empty space. Is there a specific reason for it to do use it this way?
The way I see it, you could also use the following;
And remove the check from the computed property.
The text was updated successfully, but these errors were encountered: