Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Please support self hosted runners as Executors #183

Open
1 task done
robotpistol opened this issue May 24, 2023 · 1 comment
Open
1 task done

Request: Please support self hosted runners as Executors #183

robotpistol opened this issue May 24, 2023 · 1 comment
Assignees

Comments

@robotpistol
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

We use self hosted runners in our setup but to use them we need to set resource_class to an image name like cimg/go or whatever. Right now executors in the SDK are required to be and enumerated type (small, medium, large, etc.)

https://circleci.com/docs/resource-class-overview/#introduction

Describe the solution you'd like

It would be great to have a SelfHostedExecutor type that we could leverage.

my-self-hosted-executor:
    docker:
      - image: cimg/go:1.20
    resource_class: mynamespace/myrunner

Teachability, documentation, adoption, migration strategy

Just adding a new executor type should do. But it will require modifying the AnyResourceClass type to be able to support <namespace>/<runner> strings

What is the motivation / use case for changing the behavior?

As of right now There is no good way to represent this in code. My other option is to roll it into an orb and use it that way but it seems like overkill for this case.

@KyleTryon
Copy link
Contributor

We can definitely look into this 👍 . Glad to see interest in this!

@KyleTryon KyleTryon self-assigned this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants