Using deprecated export method #30
Labels
enhancement
New feature or request
good first issue
Good for newcomers
hacktoberfest
help wanted
Extra attention is needed
The method currently used to export the TJS file is the toString method
https://github.com/Peque/sphinxcadquery/blob/0b7050c0204b8b2c6f7e6912eaee97ca02b9e776/sphinxcadquery/sphinxcadquery.py#L111
toString appears to be deprecated
https://github.com/CadQuery/cadquery/blob/05e42a75e157ed911aeef84cd7a4a864c59a5750/cadquery/occ_impl/exporters/__init__.py#L114-L118
However CadQuery offers a new method
https://github.com/CadQuery/cadquery/blob/05e42a75e157ed911aeef84cd7a4a864c59a5750/cadquery/occ_impl/exporters/__init__.py#L34-L82
That works like this...
This is not a problem quite yet but might become a problem if toString is removed in the future.
While I'm here I was wondering why the file is saved with a sha256 of the string as the file name, is this to make sure it has a unique filename?
The text was updated successfully, but these errors were encountered: