You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that the only props allowed to be passed to the component are className and children
Create a page and render a Card adding a data-testid attribute
Note that this is a valid prop in React, as are all data- attributes (also aria- attributes, e.g.)
Note that this attribute isn't rendered
Expected behavior
All components should take valid props (aka HTML attributes, including all data- attributes) for their top-level element and render them on the top-level element unless otherwise specified
At the time, our discussion approached this as an opportunity to standardize cards across the design system and figure out the role of props in the design system. This work has yet to be prioritized with CMS.
For the time being, if you still need this you could apply custom props to a div with the card CSS.
Describe the bug
Not all components render standard element props / attributes on their top-level element
Reference earlier ticket
To Reproduce
Steps to reproduce the behavior:
className
andchildren
Card
adding adata-testid
attributedata-
attributes (alsoaria-
attributes, e.g.)Expected behavior
All components should take valid props (aka HTML attributes, including all
data-
attributes) for their top-level element and render them on the top-level element unless otherwise specifiedExample:
Alert
:Takes correct props
Renders all props
Screenshots
N/A
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: