Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tice_high in init_vertical_profile for ktherm = 2 #451

Open
zhaobin74 opened this issue Aug 21, 2023 · 2 comments
Open

tice_high in init_vertical_profile for ktherm = 2 #451

zhaobin74 opened this issue Aug 21, 2023 · 2 comments
Assignees

Comments

@zhaobin74
Copy link

Hi All,

This is more of a question. In init_vertical_profile, logical tice_high is set to true if a given ice layer k has zTin above Tmlt.

if (zTin(k) > Tmax) then
tice_high = .true.

If mushy layer thermodynamic scheme is used, zTinis corrected and a warning is issued.
if (ktherm == 2) then
zqin(k) = enthalpy_of_melting(zSin(k)) - c1
zTin(k) = icepack_mushy_temperature_mush(zqin(k),zSin(k))
write(warnstr,*) subname, 'Corrected quantities'
call icepack_warnings_add(warnstr)
write(warnstr,*) subname, 'zqin=',zqin(k)
call icepack_warnings_add(warnstr)
write(warnstr,*) subname, 'zTin=',zTin(k)
call icepack_warnings_add(warnstr)

The current logic will also correct all layers below k, regardless of whether those layers have higher zTin than Tmlt, since tice_high stays True within the k-loop. My question is: is this correction of lower layers intended to be that way?

Thank you.

@apcraig
Copy link
Contributor

apcraig commented Aug 26, 2023

You could also try asking this question here, https://bb.cgd.ucar.edu/cesm/forums/cice-consortium.146/

@dabail10
Copy link
Contributor

Thanks for posting on the forum. I do think this might be a bug. Unless the intention was to reset the whole column regardless? I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants