Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sadded #391

Open
dabail10 opened this issue May 26, 2022 · 4 comments
Open

sadded #391

dabail10 opened this issue May 26, 2022 · 4 comments
Labels
Physics

Comments

@dabail10
Copy link
Contributor

Does anyone know why the sadded line in flood_ice (icepack_therm_mushy.F90) is commented out?

! sadded = wadded * ice_ref_salinity * p001
@eclare108213
Copy link
Contributor

@dabail10 you commented this (sadded) line out in PR #142
13558b2

@dabail10
Copy link
Contributor Author

I guess the more relevant question is why is sadded not used anywhere?

@eclare108213
Copy link
Contributor

Good point. wadded is not used either, except for sadded. eadded is used for an 'advective heat flux' associated with flooding. I'm not sure why mass of water and salt are not treated the same way -- they might be captured elsewhere but it's not clear. We are planning to work through all of these issues as part of the merge process.

@dabail10
Copy link
Contributor Author

Did we resolve this?

This was referenced Aug 27, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Physics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eclare108213 @apcraig @dabail10