-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrangement insert throws bad_get #8468
Comments
Let me confirm that we also have the problem in the master branch. |
It's a bug. |
I've fixed the bug. The new code resides in the rep. Aos_2-polycurve-efif
in my remote ***@***.***:efifogel/cgal.git).
I'll test it a bit further before I file a PR.
I can tell you that the code that handled intersections in the polycurve
traits was developed only with polylines (piecewise linear x-monotone
curves) in mind. The new code supports all types of x-monotone curves.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Mon, 30 Sept 2024 at 19:03, Andreas Fabri ***@***.***> wrote:
Let me confirm that we also have the problem in the master branch.
—
Reply to this email directly, view it on GitHub
<#8468 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOD7R7QS4POETWJKFOTZZFY45AVCNFSM6AAAAABN3J4HUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGYYDGNRVHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Nice, thanks for looking into this! |
Hi @lrineau, I see that the PR by Efi was closed but not merged. For me and for future reference, could you perhaps add a comment on how this issue has been fixed? |
I have no idea what happened. I never saw the PR, so it was never tested. It will be tested tonight |
Issue Details
I am using the arrangements package to create an arrangement of two closed polycurves consisting of circular arcs.
In some cases it throws the following exception on insertion of the polycurves using
CGAL::insert
.The polycurves in question in image form.
Their edges overlap:
The polycurves are well-oriented and continuous. They are self-intersecting (that is, they have identical start and end points) but this is allowed according to the documentation.
Source Code
Here is code to reproduce the issue.
header
main.h
source
main.cpp
Environment
The text was updated successfully, but these errors were encountered: