Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CGAL::IO::read_OM() #8427

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Add CGAL::IO::read_OM() #8427

wants to merge 32 commits into from

Conversation

afabri
Copy link
Member

@afabri afabri commented Aug 22, 2024 •
edited by sloriot
Loading

Summary of Changes

Add a function to read an OpenMesh file ( *.om ) in CGALlab. This file format stores also edges and vertices marked as features.
For the moment the function itself is not documented.

Release Management

  • License and copyright ownership: GeometryFactory

@afabri afabri self-assigned this Aug 22, 2024
@afabri afabri added this to the 6.1-beta milestone Aug 22, 2024
janetournois
janetournois reviewed Aug 23, 2024
View reviewed changes
Lab/demo/Lab/Plugins/IO/OM_io_plugin.cpp Outdated Show resolved Hide resolved
Lab/demo/Lab/Plugins/IO/OM_io_plugin.cpp Show resolved Hide resolved
Lab/demo/Lab/Plugins/IO/OM_io_plugin.cpp Outdated Show resolved Hide resolved
STL_Extension/include/CGAL/hash_openmesh.h Outdated Show resolved Hide resolved
Stream_support/include/CGAL/IO/OM.h Outdated Show resolved Hide resolved
Stream_support/include/CGAL/IO/OM.h Outdated Show resolved Hide resolved
@MaelRL MaelRL added the Not yet approved The feature or pull-request has not yet been approved. label Aug 27, 2024
@janetournois janetournois added the depends on another PR This pull-request should only be merged after other ones. label Sep 5, 2024
@janetournois
Copy link
Member

In the demo, loading a .om file containing a surface mesh that has no feature vertices and no feature edges should not create a selection item.
This PR should be modified to have this behaviour

@janetournois janetournois removed the depends on another PR This pull-request should only be merged after other ones. label Sep 10, 2024
@sloriot
Copy link
Member

sloriot commented Sep 17, 2024

Cannot open include file: 'CXGAL/IO/OM.h'

@sloriot
Copy link
Member

sloriot commented Sep 25, 2024 

/mnt/testsuite/test/Lab_Demo/Plugins/IO/OM_io_plugin.cpp:208:10: fatal error: om_io_plugin.moc: No such file or directory
  208 | #include "om_io_plugin.moc"

I guess you are missing something in the cmake list of the plugin

janetournois and others added 3 commits September 26, 2024 11:58
@janetournois @sloriot
fix typedefs (code review)
5f2afe2 
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
@janetournois @sloriot
add EOL
54db085 
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
@janetournois
remove debug code
5d77b6b
@sloriot
Copy link
Member

sloriot commented Oct 8, 2024 

/mnt/testsuite/test/Lab_Demo/Plugins/IO/OM_io_plugin.cpp:208:10: fatal error: om_io_plugin.moc: No such file or directory
  208 | #include "om_io_plugin.moc"

in https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0.1-Ic-342/Lab_Demo/TestReport_lrineau_Debian-Testing.gz

@janetournois @sloriot
add QUIET
b7b48b1 
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
@sloriot
Copy link
Member

sloriot commented Oct 14, 2024

ICE on MSVC 2022. See here

@sloriot
Copy link
Member

sloriot commented Oct 14, 2024

Actually there is also an ICE here so maybe it has nothing to do with this PR

@sloriot
Copy link
Member

sloriot commented Oct 18, 2024

Successfully tested in CGAL-6.0.1-Ic-351

@janetournois
move OM.h IO header to BGL package
cddb3d5 
adapt demo and examples
BGL example TriMesh.cpp does not compile
@github-actions github-actions bot removed the Tested label Oct 23, 2024
@github-actions GitHub Actions
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot
Copy link
Member

sloriot commented Oct 24, 2024

/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-3/include/CGAL/IO/polygon_mesh_io.h:84: warning: unable to resolve reference to 'IOStreamOM' for \ref command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

@janetournois janetournois janetournois left review comments

Assignees

@afabri afabri

Labels
Enhancement Not yet approved The feature or pull-request has not yet been approved. Pkg::BGL Under Testing
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@afabri @janetournois @sloriot @MaelRL