-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algebraic_kernel_d: Remove RS #8400
base: master
Are you sure you want to change the base?
Conversation
@@ -376,12 +341,6 @@ Michael Hemmer and Michael Kerber, respectively. Notwithstanding, the authors al | |||
contribution of all authors of the \exacus project, | |||
particularly the contribution of Arno Eigenwillig, Sebastian Limbach and Pavel Emeliyanenko. | |||
|
|||
The two univariate kernels that interface the library RS \cgalCite{cgal:r-rs} were |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not rewrite history like Stalin removing Trotsky from group photos. What would be a good text to say that during some time there was support for RS? @pougetma any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose to just slightly modify the text and add a bibref:
In 2010, two univariate kernels that interface the library RS \cgalCite{cgal:r-rs} were
written by Luis Peñaranda and Sylvain Lazard \cgalCite{cgal:2009-ESA}.
Both models interface the library RS \cgalCite{cgal:r-rs} by Fabrice Rouillier.
The authors want to thank Fabrice Rouillier and Elias Tsigaridas for
strong support and many useful discussions that lead to the integration of RS.
Due to lack of maintenance, these kernels have been removed in 2024.
@inproceedings{cgal:2009-ESA,
author = {Lazard, Sylvain and Pe~{n}aranda, Luis and Tsigaridas, Elias},
title = {Univariate Algebraic Kernel and Application to Arrangements},
year = {2009},
isbn = {9783642020100},
publisher = {Springer-Verlag},
address = {Berlin, Heidelberg},
url = {https://doi.org/10.1007/978-3-642-02011-7_20},
doi = {10.1007/978-3-642-02011-7_20},
booktitle = {Proceedings of the 8th International Symposium on Experimental Algorithms},
pages = {209–220},
numpages = {12},
location = {Dortmund, Germany},
series = {SEA '09}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds perfect although "lack of maintenance" is more the fact that RS is not really available. @pougetma can you just change it, or do you want me to add it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's change "Due to lack of maintenance," for "Due to lack of availability of RS," I'm fine if you commit the fix at the right place ;-) thanks!
/build:v0 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8400/v0/Manual/index.html |
Successfully tested in CGAL-6.0.1-Ic-345 |
This pull-request was previously marked with the label |
Successfully tested in CGAL-6.1-Ic-3 |
Summary of Changes
I removed RS in the third party library page, models in the documentation that are wrappers, wrappers, examples, and tests.
I did not go through the depreciation process, as I do not expect anybody to use it, as RS has no official support.
Todo: Add to the change log
Release Management