-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798
base: master
Are you sure you want to change the base?
Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798
Conversation
initial_points_generator
Allows easier initialisation
Doc added parameter + Doc make_mesh_3 + Doc Construct_initial_points_labeled_image header + Remove unwanted duplicata
/build:v0 |
There was an error while building the doc:
|
/build:v0 |
@ange-clement ange-clement removed their assignment Oct 18, 2023 |
There was an error while building the doc:
|
/build:v0 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7798/v0/Manual/index.html |
Added group "Mesh Initialization Functions" + Added concept "InitialPointsGenerator" + Documented model "Construct_initial_points_labeled_image" + Updated demo parametters + Fix reneming errors
/force-build:v0 |
There was an error while building the doc:
|
/build:v3 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7798/v3/Manual/index.html |
/force-build:v3 |
There was an error while building the doc:
|
Mesh_3/include/CGAL/Mesh_3/Construct_initial_points_labeled_image.h
Outdated
Show resolved
Hide resolved
STL_Extension/include/CGAL/STL_Extension/internal/mesh_option_classes.h
Outdated
Show resolved
Hide resolved
STL_Extension/include/CGAL/STL_Extension/internal/mesh_option_classes.h
Outdated
Show resolved
Hide resolved
* | ||
*/ | ||
template <typename MeshDomain, typename C3t3> | ||
unspecified_type initial_points(const std::vector<std::tuple<C3t3::Triangulation::Geom_traits::Weighted_point_3, int, MeshDomain::Index>>& initial_points); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see this one doesn't say the points should be on the surface. It probably should?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, but you're right I will add a comment about that
Since there is no `n` given like above, the functor must provide enough | ||
points to initialize the mesh generation process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way for the user to check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a comment explaining what is "enough", i.e. there must be at least one facet in the restricted Delaunay triangulation
Any idea why the error field of the documentation build in #7798 (comment) is empty? |
and fix doc accordingly 1. protect features 2. insert initial_points() range 3. use initial_points_generator(), if provided 4. use domain.construct_initial_points_object(), if initialization not complete
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
…' of https://github.com/ange-clement/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement
…sh-point-initialization-2-aclement # Conflicts: # Installation/CHANGES.md
/build:v4 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7798/v4/Manual/index.html |
…sh-point-initialization-2-aclement # Conflicts: # Installation/CHANGES.md
The documentation of |
Summary of Changes
Added a
initial_points_generator
parameter in make_mesh_3.With this parameter, we can use a custom functor when initializing the C3t3 complex.
This functor must follow the Initial_points_generator concept.
Tasks:
initial_points_generator
parameter inmake_mesh_3
Construct_initial_points_labeled_image
into a headerinitialize_triangulation_from_labeled_image
useConstruct_initial_points_labeled_image
InitialPointsGenerator
to outputstd::tuple<MeshDomain::Point_3, int dimension, MeshDomain::Index>
(instead ofstd::pair<MeshDomain::Point_3, MeshDomain::Index>
)initial_points_generator
parameter inmake_mesh_3
Construct_initial_points_labeled_image
headerinitialize_triangulation_from_labeled_image
andinitialize_triangulation_from_gray_image
Construct_initial_points_gray_image.h
, similar toConstruct_initial_points_labeled_image.h
CHANGES.md
, see Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798 (comment)Release Management
initialize_triangulation_from_labeled_image()
#7469