Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

ange-clement · 2023-10-13T12:56:16Z

Summary of Changes

Added a initial_points_generator parameter in make_mesh_3.
With this parameter, we can use a custom functor when initializing the C3t3 complex.
This functor must follow the Initial_points_generator concept.

Tasks:

Release Management

Affected package(s): Mesh_3
Issue(s) solved (if any):
Feature/Small Feature (if any): Mesh_3_initial_points_generator_parameter
Link to compiled documentation here:
- make_mesh_3 has been modified to receive the parameters :
  - initial_points_generator
  - initial_points
- The InitialPointsGenerator concept that the functor must be a model of.
- A model of this concept : Construct_initial_points_labeled_image
License and copyright ownership:

initial_points_generator

Allows easier initialisation

Doc added parameter + Doc make_mesh_3 + Doc Construct_initial_points_labeled_image header + Remove unwanted duplicata

ange-clement · 2023-10-18T08:32:16Z

/build:v0

github-actions · 2023-10-18T08:35:36Z

There was an error while building the doc:

/home/runner/work/cgal/cgal/Mesh_3/doc/Mesh_3/Mesh_3.txt:775: warning: unable to resolve reference to 'CGAL/Mesh_3/Construct_initial_points_labeled_image.h' for \ref command
/home/runner/work/cgal/cgal/Mesh_3/doc/Mesh_3/Mesh_3.txt:779: warning: included file CGAL/Mesh_3/Construct_initial_points_labeled_image.h is not found. Check your EXAMPLE_PATH

https://github.com/CGAL/cgal/actions/runs/6558298316

ange-clement · 2023-10-18T08:37:57Z

/build:v0

ange-clement · 2023-10-18T08:42:08Z

@ange-clement ange-clement removed their assignment Oct 18, 2023
That is an error, oops

github-actions · 2023-10-18T08:42:46Z

There was an error while building the doc:

/home/runner/work/cgal/cgal/Mesh_3/doc/Mesh_3/examples.txt:16: warning: included file CGAL/Mesh_3/Construct_initial_points_labeled_image.h is not found. Check your EXAMPLE_PATH
/home/runner/work/cgal/cgal/Mesh_3/doc/Mesh_3/Mesh_3.txt:779: warning: included file CGAL/Mesh_3/Construct_initial_points_labeled_image.h is not found. Check your EXAMPLE_PATH

https://github.com/CGAL/cgal/actions/runs/6558364305

ange-clement · 2023-10-18T09:02:18Z

/build:v0

github-actions · 2023-10-18T09:05:59Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7798/v0/Manual/index.html

Added group "Mesh Initialization Functions" + Added concept "InitialPointsGenerator" + Documented model "Construct_initial_points_labeled_image" + Updated demo parametters + Fix reneming errors

ange-clement · 2023-10-18T10:38:59Z

/force-build:v0

github-actions · 2023-10-18T10:42:22Z

There was an error while building the doc:

/home/runner/work/cgal/cgal/Mesh_3/include/CGAL/make_mesh_3.h:610: warning: Reached end of file while still inside a (nested) comment. Nesting level 1 (probable line reference: 298)
/home/runner/work/cgal/cgal/Mesh_3/include/CGAL/make_mesh_3.h:418: warning: expected <li> tag but found TK_COMMAND_BS token instead!
/home/runner/work/cgal/cgal/Mesh_3/include/CGAL/make_mesh_3.h:425: warning: Found unknown command '\cgalParamDefault'
/home/runner/work/cgal/cgal/Mesh_3/include/CGAL/make_mesh_3.h:426: warning: Found unknown command '\cgalParamSectionEnd'
/home/runner/work/cgal/cgal/Mesh_3/include/CGAL/make_mesh_3.h:427: warning: Found unknown command '\cgalNamedParamsEnd'
/home/runner/work/cgal/cgal/Mesh_3/include/CGAL/make_mesh_3.h:448: warning: unexpected end of comment while inside <dl> block
/home/runner/work/cgal/cgal/Mesh_3/doc/Mesh_3/Mesh_3.txt:775: warning: unable to resolve reference to 'CGAL/Mesh_3/Construct_initial_points_labeled_image.h' for \ref command

https://github.com/CGAL/cgal/actions/runs/6559707571

janetournois · 2024-09-24T10:26:00Z

/build:v3

github-actions · 2024-09-24T10:29:11Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7798/v3/Manual/index.html

janetournois · 2024-09-27T07:55:22Z

/force-build:v3

github-actions · 2024-09-27T07:58:21Z

There was an error while building the doc:

https://github.com/CGAL/cgal/actions/runs/11066766220

Installation/CHANGES.md

Mesh_3/doc/Mesh_3/CGAL/Mesh_3/parameters.h

Mesh_3/include/CGAL/Mesh_3/Construct_initial_points_labeled_image.h

STL_Extension/include/CGAL/STL_Extension/internal/mesh_option_classes.h

MaelRL · 2024-09-27T08:44:32Z

Mesh_3/doc/Mesh_3/CGAL/Mesh_3/parameters.h

+ *
+ */
+template <typename MeshDomain, typename C3t3>
+unspecified_type initial_points(const std::vector<std::tuple<C3t3::Triangulation::Geom_traits::Weighted_point_3, int, MeshDomain::Index>>& initial_points);


As far as I see this one doesn't say the points should be on the surface. It probably should?

not really, but you're right I will add a comment about that

MaelRL · 2024-09-27T08:45:24Z

Mesh_3/doc/Mesh_3/Concepts/InitialPointsGenerator.h

+Since there is no `n` given like above, the functor must provide enough
+points to initialize the mesh generation process.


Is there a way for the user to check this?

I have added a comment explaining what is "enough", i.e. there must be at least one facet in the restricted Delaunay triangulation

albert-github · 2024-09-27T08:54:42Z

Any idea why the error field of the documentation build in #7798 (comment) is empty?

and fix doc accordingly 1. protect features 2. insert initial_points() range 3. use initial_points_generator(), if provided 4. use domain.construct_initial_points_object(), if initialization not complete

Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>

…' of https://github.com/ange-clement/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement

…sh-point-initialization-2-aclement # Conflicts: # Installation/CHANGES.md

janetournois · 2024-09-30T12:30:17Z

/build:v4

github-actions · 2024-10-09T09:38:32Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7798/v4/Manual/index.html

…sh-point-initialization-2-aclement # Conflicts: # Installation/CHANGES.md

janetournois · 2024-10-23T14:50:47Z

The documentation of CGAL::make_mesh_3() with the new named parameters initial_points() and initial_points_generator() is available here

@lrineau

Implemented make_mesh_3 param :

3937c5d

initial_points_generator

ange-clement mentioned this pull request Oct 13, 2023

Mesh 3 : initial_points parameter for domain point initialization #7757

Closed

13 tasks

janetournois assigned ange-clement Oct 13, 2023

janetournois added Pkg::Mesh_3 Feature request labels Oct 13, 2023

janetournois added this to the 6.0-beta milestone Oct 13, 2023

ange-clement added 10 commits October 16, 2023 10:17

Fix CI

2732dad

Fix CI

bec5358

Fix CI

0d0c1f3

Fix CI

9fc7230

Use parameters instead of template

f2af654

Allows easier initialisation

Fix CI confusion between typedef and struct

268fd8b

Doc change + small fix

4ee4dff

Fix error when no initial_points_generator

c232929

Fix unvoluntary copy

e5d2651

Doc changed example +

cb71595

Doc added parameter + Doc make_mesh_3 + Doc Construct_initial_points_labeled_image header + Remove unwanted duplicata

Fixed doc

6558190

ange-clement removed their assignment Oct 18, 2023

Renamed Construct_initial_points_from_labeled_image.h

91d66d0

Updated doc example snippets +

23af3eb

Added group "Mesh Initialization Functions" + Added concept "InitialPointsGenerator" + Documented model "Construct_initial_points_labeled_image" + Updated demo parametters + Fix reneming errors

Fix Doc missing end of description

932e8a2

update doc

490a6ad

janetournois added 3 commits September 26, 2024 11:02

remove useless generator() accessor

f4e2b3d

doc

8d6e7f2

doc

f3b5333

MaelRL reviewed Sep 27, 2024

View reviewed changes

janetournois and others added 12 commits September 30, 2024 11:10

make initialization logic consistent

88457ee

and fix doc accordingly 1. protect features 2. insert initial_points() range 3. use initial_points_generator(), if provided 4. use domain.construct_initial_points_object(), if initialization not complete

mention features initialization in the insertion order description

76ee84e

cleaning

f0ad731

doc (Mael's review)

f3b9a5a

apply Mael's suggestions

9645589

Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>

remove outdated named parameter

7c4ab1c

Merge branch 'Mesh-3-rework-make-mesh-point-initialization-2-aclement…

883f062

…' of https://github.com/ange-clement/cgal into Mesh-3-rework-make-mesh-point-initialization-2-aclement

cleaning

32f147f

move to 6.1

74cd65e

Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…

c1f2236

…sh-point-initialization-2-aclement # Conflicts: # Installation/CHANGES.md

doc

4573f78

doc

435ea6e

This comment has been minimized.

Sign in to view

janetournois requested a review from lrineau October 10, 2024 08:08

Merge remote-tracking branch 'cgal/master' into Mesh-3-rework-make-me…

f77f9c6

…sh-point-initialization-2-aclement # Conflicts: # Installation/CHANGES.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

ange-clement commented Oct 13, 2023 •

edited by janetournois

Loading

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

ange-clement commented Oct 18, 2023

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

janetournois commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

janetournois commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

MaelRL Sep 27, 2024

janetournois Sep 30, 2024

MaelRL Sep 27, 2024

janetournois Sep 30, 2024

albert-github commented Sep 27, 2024

janetournois commented Sep 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 9, 2024

janetournois commented Oct 23, 2024

		Since there is no `n` given like above, the functor must provide enough
		points to initialize the mesh generation process.

Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

Are you sure you want to change the base?

Mesh 3 : initial_points_generator parameter for make_mesh_3 point initialization #7798

Conversation

ange-clement commented Oct 13, 2023 • edited by janetournois Loading

Summary of Changes

Release Management

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

ange-clement commented Oct 18, 2023

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

ange-clement commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

janetournois commented Sep 24, 2024

github-actions bot commented Sep 24, 2024

janetournois commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

MaelRL Sep 27, 2024

Choose a reason for hiding this comment

janetournois Sep 30, 2024

Choose a reason for hiding this comment

MaelRL Sep 27, 2024

Choose a reason for hiding this comment

janetournois Sep 30, 2024

Choose a reason for hiding this comment

albert-github commented Sep 27, 2024

janetournois commented Sep 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 9, 2024

janetournois commented Oct 23, 2024

ange-clement commented Oct 13, 2023 •

edited by janetournois

Loading