Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-related changes #352

Open
cua-cua opened this issue Nov 25, 2018 · 0 comments
Open

API-related changes #352

cua-cua opened this issue Nov 25, 2018 · 0 comments

Comments

@cua-cua
Copy link
Member

cua-cua commented Nov 25, 2018

module_name style

  • modify the public function names so they include the name of their module that it is also the name of the file where are defined

move.c / speed.c functions:

  • calibration.c: change cases with move_side to move
  • "We should probably move turn_back to speed module. Turn back should probably be a speed_turn() with 180-degree turn. If there is a front-wall adjustment it should be called move_back(). We have a function named like that to get out of a dead-end, so if we want to have a static turn back with front-wall adjustment we should probably call it turn_back_static() or something like that."
  • Implement speed parametrization on front movements
  • Rename or redesign the method 'parametric_move_front(float distance, float end_linear_speed)' to differentiate side_sensors_control behaviour between diagonals and straight cases.

control.c:

  • Should we create a new abstraction layer to "float get_measured_angular_speed" type of functions?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants