You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I commented after the fix for the original issue #57 , cancelGoal() still doesn't work correctly for pre-response action cancellation. The issue now is, that goal_handle_ is not reset after a previous goal has terminated, which causes this condition to always become true after the first goal response. Therefore the function misleadingly assumes for any subsequent goals that the corresponding response has already arrived. As a result, an rclcpp_action::UnkownGoalError is thrown in action_client->async_get_result() if cancelGoal() is called when the current goal has not arrived yet, since goal_handle_ refers to the previous, already terminated goal.
We either have to reset goal_handle_ appropriately, or refer to the currently relevant goal uuid if we want to verify that the response has arrived.
I also suggested an entirely different implementation of RosActionNodehere, which would prevent this issue from ocurring in the first place (Behavior A: Wait for goal response during initial tick).
The text was updated successfully, but these errors were encountered:
robin-mueller
changed the title
#57 works only reliably for the very first goal
Fix for #57 works only reliably for the very first goal
May 20, 2024
robin-mueller
changed the title
Fix for #57 works only reliably for the very first goal
Fix for #57 only works reliably for the very first goal
May 22, 2024
As I commented after the fix for the original issue #57 ,
cancelGoal()
still doesn't work correctly for pre-response action cancellation. The issue now is, thatgoal_handle_
is not reset after a previous goal has terminated, which causes this condition to always become true after the first goal response. Therefore the function misleadingly assumes for any subsequent goals that the corresponding response has already arrived. As a result, anrclcpp_action::UnkownGoalError
is thrown inaction_client->async_get_result()
ifcancelGoal()
is called when the current goal has not arrived yet, sincegoal_handle_
refers to the previous, already terminated goal.We either have to reset
goal_handle_
appropriately, or refer to the currently relevant goal uuid if we want to verify that the response has arrived.I also suggested an entirely different implementation of
RosActionNode
here, which would prevent this issue from ocurring in the first place (Behavior A: Wait for goal response during initial tick).The text was updated successfully, but these errors were encountered: