-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Compare installation toolsets #5064
Comments
What is missing for this task? |
Toolsets comparation and final decision which one to use |
InnoSetup: Pretty easy and straightforward for simple stuff. Doesn't appear to have command line interface to compile installer with script. Seems to be Pascal oriented? All three tools have great documentation, although I found NSIS and WiX documentation easier to navigate and understand than InnoSetup. In my opinion WiX Toolset would be the best for BOINC, as we use Visual Studio, and WiX is supported trough HeatWave extension. |
Preferable tool that can compile and create on the ci. |
I can try to craft up examples. Not today though. Would you like one for each or just for WiX? I'm not sure if InnoSetup is CI compatible at all :) |
@Frigyes06, thank you for the input. Yes, I have a simple sample of NSIS but I doubt we will use it. @talregev, all three toolsets could be built on ci. |
Can you specify all the requirements for the toolset? |
I don't have a complete list of requirements for now, so when I have it - I update this ticket. |
Ok, requirements are there. I hope I didn't forget anything important. |
@AenBleidd Thank you. Please also put issues that we want to solve that the new installer should hold. @Frigyes06 Are you interesting to do this research? |
Please check #5066 |
I see you include #5118 as almost the last in this long list. This issue need to investigated in the research part, and not in the end. Also we need more issues like it that are important to boinc. Please make that list. Thank you. |
These issues are not ordered. This is just a list. Last doesn't mean has less importance.
In any case this is not a top priority issue. Also, it's actually not related to the installer script itself but to the custom dll that is run from the installer. And since it's currently not known whether we will keep existing dll or completely replace it (in case the new installation toolset won't be able to call functions from the dll during installation and this is the only disadvantage of it).
This list is already in #5066. Everything else could be added later while working on the new installer. As you understand, the prio one task is to convert existing installation script to the new toolset keeping all or almost all existing functionality. We have no outdated settings there, so we need to preserve them all for smooth user experience: in the best case user should not mention that they are running a new installer. |
You didn't explain why we don't need to make an effort and invest time in research to see if new installer will solve the known bugs.
Try to fix know bug after you choose a installer it much harder. This is not connected to agile or waterfall. In both system you need invest time to choose the right tool for the job. Known issues is a great starting point. |
Because this issue is not related to the installer. And while choosing the proper toolset you should not consider existing bugs in existing installer but rather stick to the general requirements that are listed in the first comment. |
I am talking to add similar known bugs that important for the research , not this issue itself.
You are the maintainer of this repo. You are know better than me what is important to boinc. Also you are the one that go all over the issues and categorize it. You know better then anyone whats issues are good to investigated to this research and you should add them. Also known issues is just part of the research. Also needed the requirement as you specify. |
All these issues are listed in #5066. |
This is mixed from task that need to do with some known issue. I recognize only one. That why we should only the known issue to this issue. |
Ok, I'll repeat this the third time: while doing research to choose new installation toolset you should stick to the requirements only and forget about existing issues of the current installer. Is that clear? |
I already explain why is it important to have also the known issues in the research for the new installer. You are proposing non professional way. |
Yeah, I can do this. I estimate it will be done by wednesday. |
If you want - you're free to do that.
This is your personal opinion. If you want to do this task your way - I can't stop you from doing that. For me to make a decision about the next toolset we will use for BOINC - is to met requirements I listed in the first message. |
Thank you! |
Take your time: sometimes it's better to spend more time to make the best decision |
It might not be a hard requirement, but InstallShield is set up to digitally sign the executables included in the installer (boinc.exe, boincmgr.exe, etc). Worst case, this could probably be scripted independently, but it would be nice if the toolset included some level of integration. Otherwise, I think the list of requirements looks pretty good. I'll be glad to take part in some testing of toolsets once we get there. I build some custom installers for account managers, but generally they don't stray too far from following the standard BOINC process. |
Executables inside installer are already signed with Visual Studio. @tristanolive, I'll let you know when we have something to test. Thank you for your help. |
Right you are, InstallShield only signs the additional files that it is producing. I'm not sure what the purpose would be of some of that; files such as "D.tmp" or "certificate.msi". The final step of signing the installer itself would still be significant, but that is easy to do manually. Thanks for setting the details straight! |
According to the comparation table, the best tool to use is |
There are 3 possible candidates to be used to create new Windows Installer:
It's required to compare these 3 solutions and choose one that will fit best for BOINC.
Comparation matrix
Legend
The text was updated successfully, but these errors were encountered: