From 8a68fc164a3c31361c01c996eed8a454c48fd9d9 Mon Sep 17 00:00:00 2001
From: David Anderson <davea@ssl.berkeley.edu>
Date: Sat, 6 Jul 2024 02:11:37 -0700
Subject: [PATCH] client: don't put HTML in event log messages

(affects only 'new client version' message AFAIK)
---
 client/client_msgs.cpp     | 30 +++++++++++++++++++++---------
 client/current_version.cpp | 26 +++++++++++++-------------
 2 files changed, 34 insertions(+), 22 deletions(-)

diff --git a/client/client_msgs.cpp b/client/client_msgs.cpp
index 669e70e217..b9dbb4cc39 100644
--- a/client/client_msgs.cpp
+++ b/client/client_msgs.cpp
@@ -62,13 +62,8 @@ void show_message(
     //
     diagnostics_cycle_logs();
 
-    strlcpy(message, msg, sizeof(message));
-
-    // trim trailing \n's
-    //
-    while (strlen(message) && message[strlen(message)-1] == '\n') {
-        message[strlen(message)-1] = 0;
-    }
+    safe_strcpy(message, msg);
+    strip_whitespace(message);
 
     // add a message
     //
@@ -84,9 +79,22 @@ void show_message(
     default:
         strlcpy(event_msg, message, sizeof(event_msg));
     }
+
+    // The event log doesn't display HTML, so strip tags
+    // The only case of this is
+    // A new version of BOINC is available (8.0.2). <a href=https://boinc.berkeley.edu/download.php>Download</a>
+    // so do it in a crude way.
+    //
+    if (is_html) {
+        char *q = strchr(event_msg, '<');
+        if (q) {
+            *q = 0;
+            strip_whitespace(event_msg);
+        }
+    }
     message_descs.insert(p, priority, (int)t, event_msg);
 
-    // add a notice
+    // add a notice if needed
     //
     switch (priority) {
     case MSG_USER_ALERT:
@@ -151,7 +159,11 @@ void msg_printf(PROJ_AM *p, int priority, const char *fmt, ...) {
     show_message(p, buf, priority, true, 0);
 }
 
-void msg_printf_notice(PROJ_AM *p, bool is_html, const char* link, const char *fmt, ...) {
+void msg_printf_notice(
+    PROJ_AM *p,
+    bool is_html,   // msg has HTML tags; don't XML-escape it
+    const char* link, const char *fmt, ...
+) {
     char buf[8192];  // output can be much longer than format
     va_list ap;
 
diff --git a/client/current_version.cpp b/client/current_version.cpp
index 24b6a11ab1..235d78f874 100644
--- a/client/current_version.cpp
+++ b/client/current_version.cpp
@@ -202,10 +202,10 @@ static bool parse_version(FILE* f, char* new_version, int len) {
         if (xp.match_tag("/version")) {
 #ifdef __APPLE__
             return (same_platform
-                    && newer_version_exists
-                    && min_macos_OK
-                    && max_macos_OK
-                );
+                && newer_version_exists
+                && min_macos_OK
+                && max_macos_OK
+            );
 #else
             return (same_platform && newer_version_exists);
 #endif
@@ -215,11 +215,11 @@ static bool parse_version(FILE* f, char* new_version, int len) {
         }
         if (xp.parse_str("version_num", buf2, sizeof(buf2))) {
             newer_version_exists = is_version_newer(
-                                    buf2,
-                                    gstate.core_client_version.major,
-                                    gstate.core_client_version.minor,
-                                    gstate.core_client_version.release
-                                    );
+                buf2,
+                gstate.core_client_version.major,
+                gstate.core_client_version.minor,
+                gstate.core_client_version.release
+            );
             strlcpy(new_version, buf2, len);
         }
 #ifdef __APPLE__
@@ -307,10 +307,10 @@ void newer_version_startup_check() {
 
     if (!gstate.newer_version.empty()) {
         if (is_version_newer(gstate.newer_version.c_str(),
-                            gstate.core_client_version.major,
-                            gstate.core_client_version.minor,
-                            gstate.core_client_version.release)
-                            ) {
+            gstate.core_client_version.major,
+            gstate.core_client_version.minor,
+            gstate.core_client_version.release)
+        ) {
             show_newer_version_msg(gstate.newer_version.c_str());
         } else {
             gstate.newer_version = "";