Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Attach/Detach data disks APIs support for VMs and VMSS #38030

Open
alexn-orca opened this issue Oct 22, 2024 · 3 comments
Open

New Attach/Detach data disks APIs support for VMs and VMSS #38030

alexn-orca opened this issue Oct 22, 2024 · 3 comments
Assignees
Labels
Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@alexn-orca
Copy link

On the 18th of October Azure introduced the new APIs for attaching and detaching data disks for VMs and VMSS.

I would like to have wrappers on those APIs available in Azure python SDK, to me able to attach/detach data volumes without calling update VM operation.

Currently I do this:

    data_disk_update = (virtual_machine.storage_profile.data_disks or []) + [  # type: ignore
        {
            "lun": len(virtual_machine.storage_profile.data_disks),  # type: ignore  # can be 0-15
            # 'name': volume['name'],
            "create_option": DiskCreateOption.attach,
            "managed_disk": {"id": volume_id},
        }
    ]
    virtual_machine_update = {"storage_profile": {"data_disks": data_disk_update}}
  async_disk_attach = await compute_client.virtual_machines.begin_update(rg_name, vm_name, )
  await async_disk_attach.result()

What I want to be able to do:
async_disk_attach = await compute_client.virtual_machines.attach_volume(rg_name, vm_name, volumes)

@github-actions github-actions bot added Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. labels Oct 22, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3 @TravisCragg-MSFT.

@TravisCragg-MSFT TravisCragg-MSFT removed the Service Attention Workflow: This issue is responsible by Azure service team. label Oct 22, 2024
@github-actions github-actions bot added the needs-team-triage Workflow: This issue needs the team to triage. label Oct 22, 2024
@xiangyan99 xiangyan99 added feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Oct 23, 2024
@xiangyan99
Copy link
Member

Thanks for the feedback, we’ll investigate asap.

@msyyc
Copy link
Member

msyyc commented Oct 23, 2024

@ChenxiJiang333 Please help on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compute - VM customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

No branches or pull requests

4 participants