-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: enable infra generation #4475
base: main
Are you sure you want to change the base?
Conversation
azd's AVM monitoring module provides the same functionality. Use that instead
update next-steps documentation
7651552
to
cc08f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments. Nothing really blocking
if im.dotNetImporter.alphaFeatureManager.IsEnabled(alpha.FeatureId(alpha.Compose)) && len(projectConfig.Resources) > 0 { | ||
return infraFsForProject(ctx, projectConfig) | ||
} | ||
|
||
return nil, fmt.Errorf("this project does not contain any infrastructure to synthesize") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the alpha-feature is not enabled, are we printing this error message about there's not infra to synth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the suggestion. Thanks! We can definitely consider a better error message for enablement.
e2b12da
to
1dc68e2
Compare
1dc68e2
to
89059c6
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Enables infra generation, i.e. temporary infrastructure and synthesized infrastructure from resources.
Contributes to #4397, https://github.com/Azure/azure-dev-pr/issues/1682