Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Introduce template tests for idempotency #3382

Open
AlexanderSehr opened this issue Jun 29, 2023 · 2 comments
Open

[Feature Request]: Introduce template tests for idempotency #3382

AlexanderSehr opened this issue Jun 29, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@AlexanderSehr
Copy link
Contributor

Description

To further validate our templates, we could introduce an 'idempotency' test. This effectively means that we'd need to update our deployment script to deploy the same template at least one more time following a preceeding successful deployment.

Note: This will likely lead to some pipelines failing as not all services / their features are idempontent. Synapse Workspace encryption comes to mind.
Following the implementation, we should run the tests for all pipelines to identify those modules and try and find a reasonable solution.

Note: Probably the trickiest part about the implementation will be to properly work together with the already existing 'retry' logic.

@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Jun 29, 2023
@eriqua
Copy link
Contributor

eriqua commented Jul 5, 2023

We should also consider gh hosted runners job duration limitations (6h) for services taking multiple hours to deploy (e.g., sqlmi) although, if idempotent, the second deployment would likely take a limited time to just check that all resources are deployed already.
In case of canceled jobs, the deployment may continue in Azure without it being logged.

@AlexanderSehr
Copy link
Contributor Author

We should also consider gh hosted runners job duration limitations (6h) for services taking multiple hours to deploy (e.g., sqlmi) although, if idempotent, the second deployment would likely take a limited time to just check that all resources are deployed already. In case of canceled jobs, the deployment may continue in Azure without it being logged.

Agreed. Something we can maybe solve by not running the 2nd deployment in the same job

@AlexanderSehr AlexanderSehr added this to the Azure Verfified Modules (AVM) - V3 milestone Aug 7, 2023
@AlexanderSehr AlexanderSehr removed this from the Azure Verfified Modules (AVM) - CI Issues milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants