Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoclue-2.0 robustness #82

Open
sunweaver opened this issue Nov 18, 2023 · 1 comment
Open

geoclue-2.0 robustness #82

sunweaver opened this issue Nov 18, 2023 · 1 comment

Comments

@sunweaver
Copy link
Member

The geoclue-2.0 bit in display indicator requires a user daemon running (/usr/lib/geoclue-2.0/demos/agent).

This agent can be used to kill geoclue-2.0 service access (kill the daemon, then there are no location services available anymore via geoclue-2.0).

If someone choose to disable the geoclue-2.0 agent (launched via XDG autostart), display indicator should silently ignore missing geolocation support and run happily without it (hiding the geo location based features).

This also goes further, the indicator tears its renderer down if geoclue-2.0 agent is not running, e.g. in MATE:

  • Log into a normal MATE session
  • kill /usr/lib/geoclue-2.0/demos/agent
  • (make sure it does not come back)
  • kill the display indicator process
  • launch the display indicator again via a terminal
  • (icon appears)
  • click on the display indicator icon ----> BOOOM (mate-indicator-applet gone)
  • when mate-indicator-applet comes back (and display indicator is already running), one can click on the display indicator icon and menus appear...
@tari01
Copy link
Member

tari01 commented Jun 24, 2024

If someone choose to disable the geoclue-2.0 agent (launched via XDG autostart), display indicator should silently ignore missing geolocation support and run happily without it (hiding the geo location based features).

It already does this. If it cannot connect to the GeoClue2 service, it will spit out a warning and use a fallback location.

* click on the display indicator icon ----> BOOOM (mate-indicator-applet gone)

This is not related to GeoClue2. All system indicators do this the first time the menu is about to drop down. It happens only when they are started manually.


I propose we close this, since GeoClue2 + Display Indicator are not at fault here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants