Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertDialog disappears on orientation change #842

Open
nicolarevelant opened this issue Sep 25, 2024 · 0 comments
Open

AlertDialog disappears on orientation change #842

nicolarevelant opened this issue Sep 25, 2024 · 0 comments

Comments

@nicolarevelant
Copy link

nicolarevelant commented Sep 25, 2024

1. Environment

  • Device: [Xiaomi Redmi Note 8 Pro]
  • OS: [Android 14]
  • APP: [0.9.12]

Note: not fixed in 0.10.1

2. Describe the bug

Problem: when I perform this sequence of events the AlertDialog disappears:

  1. Touch the settings icon at the top left
  2. Touch Accounts
  3. Open an account
  4. Touch one of the following:
    1. Display, then Name
    2. Syncing, then Sync
    3. Syncing, then Keep achieved articles
    4. Syncing, then Export as OPML
  5. Rotate the device twice

or:

  1. Touch the settings icon at the top left
  2. Touch Color & style
  3. Touch Basic fonts
  4. Rotate the device twice

or:

  1. Touch the settings icon at the top left
  2. Touch Color & style
  3. Touch Feeds Page
  4. Touch one of the following:
    1. TopBar, then Tonal elevation
    2. Group List, then Tonal elevation
    3. Filter Bar, then Style
    4. Filter Bar, then Horizontal padding
    5. Filter Bar, then Tonal elevation
  5. Rotate the device twice

or:

  1. Touch the settings icon at the top left
  2. Touch Color & style
  3. Touch Flow Page
  4. Touch one of the following:
    1. TopBar, then Tonal elevation
    2. Article List, then Grey out articles
    3. Article List, then Tonal elevation
    4. Filter Bar, then Style
    5. Filter Bar, then Horizontal padding
    6. Filter Bar, then Tonal elevation
  5. Rotate the device twice

or:

  1. Touch the settings icon at the top left
  2. Touch Color & style
  3. Touch Reading Page
  4. Touch one of the following:
    1. Reading fonts
    2. Tonal elevation
    3. Title, then Alignment
    4. Text, then Font Size
    5. Text, then Letter spacing
    6. Text, then Horizontal padding
    7. Text, then Alignment
    8. Images, then Rounded corners
    9. Images, then Horizontal padding
  5. Rotate the device twice

Possible solution:

use rememberSaveable instead of remember in the following occurrencies:

  • app/src/main/java/me/ash/reader/ui/page/settings/accounts/AccountDetailsPage.kt:77, 83, 84, 85
  • app/src/main/java/me/ash/reader/ui/page/settings/color/ColorAndStylePage.kt:59
  • app/src/main/java/me/ash/reader/ui/page/settings/color/feeds/FeedsPageStylePage.kt:40, 41, 42, 43, 44
  • app/src/main/java/me/ash/reader/ui/page/settings/color/flow/FlowPageStylePage.kt:46-51
  • app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingStylePage.kt:51, 52
  • app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingTitlePage.kt:39
  • app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingTextPage.kt:39-42
  • app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingImagePage.kt:32, 33

Screenshots:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant