Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlapFilterCallback should be abstract #25

Open
zdimension opened this issue Dec 3, 2016 · 3 comments
Open

OverlapFilterCallback should be abstract #25

zdimension opened this issue Dec 3, 2016 · 3 comments

Comments

@zdimension
Copy link

No description provided.

@Inverness
Copy link

Inverness commented Feb 16, 2017

Echoing this. The NeedsBroadphaseCollision method is also not virtual. Please fix this.

Edit: Also, the Bullet manual suggests overriding btCollisionDispatcher for virtual methods needsCollision(), needsResponse, and dispatchAllCollisionPairs. I don't see virtual methods for any of these in C#.

Could you please verify that those things that should be override-able are properly exposed?

@AndresTraks
Copy link
Owner

Done in 99d1738.

@AndresTraks
Copy link
Owner

CollisionDispatcher will take some more time. Making C++ classes inheritable in C# is not very straight-forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants