perf: remove XValue unit value combinations #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removes all XValue classes The intention is to replace these with validators to check that units are included with values
7 tasks
|
Changed this to merge into a "v1" branch instead of main |
saskiad
approved these changes
Oct 17, 2024
dbirman
deleted the
86-deprecate-or-remove-if-unused-xvalue-classes-from-unitspy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes all XValue classes
The intention is to replace these with validators to check that units are included with values
There are only a few places these are being used:
https://github.com/AllenNeuralDynamics/SPIM-UI-Launch/blob/342d357be6aec3798aefe3b6d6ed4d1397678d57/exaSPIM/exaSPIM-UI-Luanch.py#L5
https://github.com/AllenNeuralDynamics/SPIM-UI-Launch/blob/342d357be6aec3798aefe3b6d6ed4d1397678d57/iSPIM/iSPIM-UI-Launch.py#L5
and a few places in aind-data-schema although confusingly it's used in the tests but not in the actual schema?