Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeaveTimeBatchBuilder#batch_join_date_based_import 有無意義的判斷式 #170

Open
YushengLi opened this issue Jun 23, 2017 · 0 comments
Open

LeaveTimeBatchBuilder#batch_join_date_based_import 有無意義的判斷式 #170

YushengLi opened this issue Jun 23, 2017 · 0 comments

Comments

@YushengLi
Copy link
Contributor

https://github.com/5xRuby/daikichi/blob/development/app/services/leave_time_batch_builder.rb#L17

看起來 #batch_join_date_based_import 跟 reaching_join_date 是相同的，同時 Query 的條件也相同，確認無誤後移除無意義的判斷式。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YushengLi